CC: [email protected] In-Reply-To: <[email protected]> References: <[email protected]> TO: Alexey Dobriyan <[email protected]> TO: [email protected] CC: [email protected]
Hi Alexey, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Alexey-Dobriyan/netlink-gc-useless-variable-in-nlmsg_attrdata/20210813-052557 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git bed5a942e27e1df67250e27e1f2eb5ea2d4cc362 :::::: branch date: 5 hours ago :::::: commit date: 5 hours ago config: i386-randconfig-m021-20210812 (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> Reported-by: Dan Carpenter <[email protected]> New smatch warnings: net/ipv4/inet_diag.c:219 inet_diag_parse_attrs() warn: potential spectre issue 'req_nlas' [w] (local cap) Old smatch warnings: include/linux/cgroup-defs.h:817 sock_cgroup_classid() warn: maybe use && instead of & vim +/req_nlas +219 net/ipv4/inet_diag.c cb2050a7b8131a9 Xin Long 2016-04-14 205 d5e4d0a5e692a94 Eric Dumazet 2020-09-21 206 static int inet_diag_parse_attrs(const struct nlmsghdr *nlh, int hdrlen, 3f935c75eb52dd9 Paolo Abeni 2020-07-09 207 struct nlattr **req_nlas) 3f935c75eb52dd9 Paolo Abeni 2020-07-09 208 { 3f935c75eb52dd9 Paolo Abeni 2020-07-09 209 struct nlattr *nla; 3f935c75eb52dd9 Paolo Abeni 2020-07-09 210 int remaining; 3f935c75eb52dd9 Paolo Abeni 2020-07-09 211 3f935c75eb52dd9 Paolo Abeni 2020-07-09 212 nlmsg_for_each_attr(nla, nlh, hdrlen, remaining) { 3f935c75eb52dd9 Paolo Abeni 2020-07-09 213 int type = nla_type(nla); 3f935c75eb52dd9 Paolo Abeni 2020-07-09 214 d5e4d0a5e692a94 Eric Dumazet 2020-09-21 215 if (type == INET_DIAG_REQ_PROTOCOL && nla_len(nla) != sizeof(u32)) d5e4d0a5e692a94 Eric Dumazet 2020-09-21 216 return -EINVAL; d5e4d0a5e692a94 Eric Dumazet 2020-09-21 217 3f935c75eb52dd9 Paolo Abeni 2020-07-09 218 if (type < __INET_DIAG_REQ_MAX) 3f935c75eb52dd9 Paolo Abeni 2020-07-09 @219 req_nlas[type] = nla; 3f935c75eb52dd9 Paolo Abeni 2020-07-09 220 } d5e4d0a5e692a94 Eric Dumazet 2020-09-21 221 return 0; 3f935c75eb52dd9 Paolo Abeni 2020-07-09 222 } 3f935c75eb52dd9 Paolo Abeni 2020-07-09 223 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected]
.config.gz
Description: application/gzip
_______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
