CC: [email protected] CC: Linux Memory Management List <[email protected]> TO: Linus Walleij <[email protected]> CC: Kalle Valo <[email protected]>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 9b992972fb9c2a1bc3fb25bab70da8a4385e3abe commit: 5ff013914c62c493c206d70554cfb1d311ea481a [4136/7554] brcmfmac: firmware: Allow per-board firmware binaries :::::: branch date: 18 hours ago :::::: commit date: 12 days ago config: openrisc-randconfig-m031-20210812 (attached as .config) compiler: or1k-linux-gcc (GCC) 10.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> Reported-by: Dan Carpenter <[email protected]> smatch warnings: drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c:709 brcmf_fw_get_firmwares() error: uninitialized symbol 'ret'. vim +/ret +709 drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c d09ae51a4b6761 drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c Arend Van Spriel 2018-03-22 675 d09ae51a4b6761 drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c Arend Van Spriel 2018-03-22 676 int brcmf_fw_get_firmwares(struct device *dev, struct brcmf_fw_request *req, 6d0507a777fbc5 drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c Arend Van Spriel 2017-06-12 677 void (*fw_cb)(struct device *dev, int err, d09ae51a4b6761 drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c Arend Van Spriel 2018-03-22 678 struct brcmf_fw_request *req)) c1416e77a61667 drivers/net/wireless/brcm80211/brcmfmac/firmware.c Arend van Spriel 2014-05-27 679 { 5b587496dc6359 drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c Hans de Goede 2018-10-10 680 struct brcmf_fw_item *first = &req->items[0]; c1416e77a61667 drivers/net/wireless/brcm80211/brcmfmac/firmware.c Arend van Spriel 2014-05-27 681 struct brcmf_fw *fwctx; 5ff013914c62c4 drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c Linus Walleij 2021-07-12 682 char *alt_path; 5b587496dc6359 drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c Hans de Goede 2018-10-10 683 int ret; c1416e77a61667 drivers/net/wireless/brcm80211/brcmfmac/firmware.c Arend van Spriel 2014-05-27 684 c1416e77a61667 drivers/net/wireless/brcm80211/brcmfmac/firmware.c Arend van Spriel 2014-05-27 685 brcmf_dbg(TRACE, "enter: dev=%s\n", dev_name(dev)); d09ae51a4b6761 drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c Arend Van Spriel 2018-03-22 686 if (!fw_cb) c1416e77a61667 drivers/net/wireless/brcm80211/brcmfmac/firmware.c Arend van Spriel 2014-05-27 687 return -EINVAL; c1416e77a61667 drivers/net/wireless/brcm80211/brcmfmac/firmware.c Arend van Spriel 2014-05-27 688 d09ae51a4b6761 drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c Arend Van Spriel 2018-03-22 689 if (!brcmf_fw_request_is_valid(req)) c1416e77a61667 drivers/net/wireless/brcm80211/brcmfmac/firmware.c Arend van Spriel 2014-05-27 690 return -EINVAL; c1416e77a61667 drivers/net/wireless/brcm80211/brcmfmac/firmware.c Arend van Spriel 2014-05-27 691 c1416e77a61667 drivers/net/wireless/brcm80211/brcmfmac/firmware.c Arend van Spriel 2014-05-27 692 fwctx = kzalloc(sizeof(*fwctx), GFP_KERNEL); c1416e77a61667 drivers/net/wireless/brcm80211/brcmfmac/firmware.c Arend van Spriel 2014-05-27 693 if (!fwctx) c1416e77a61667 drivers/net/wireless/brcm80211/brcmfmac/firmware.c Arend van Spriel 2014-05-27 694 return -ENOMEM; c1416e77a61667 drivers/net/wireless/brcm80211/brcmfmac/firmware.c Arend van Spriel 2014-05-27 695 c1416e77a61667 drivers/net/wireless/brcm80211/brcmfmac/firmware.c Arend van Spriel 2014-05-27 696 fwctx->dev = dev; d09ae51a4b6761 drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c Arend Van Spriel 2018-03-22 697 fwctx->req = req; c1416e77a61667 drivers/net/wireless/brcm80211/brcmfmac/firmware.c Arend van Spriel 2014-05-27 698 fwctx->done = fw_cb; c1416e77a61667 drivers/net/wireless/brcm80211/brcmfmac/firmware.c Arend van Spriel 2014-05-27 699 5ff013914c62c4 drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c Linus Walleij 2021-07-12 700 /* First try alternative board-specific path if any */ 5ff013914c62c4 drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c Linus Walleij 2021-07-12 701 alt_path = brcm_alt_fw_path(first->path, fwctx->req->board_type); 5ff013914c62c4 drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c Linus Walleij 2021-07-12 702 if (alt_path) { 5ff013914c62c4 drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c Linus Walleij 2021-07-12 703 ret = request_firmware_nowait(THIS_MODULE, true, alt_path, 5ff013914c62c4 drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c Linus Walleij 2021-07-12 704 fwctx->dev, GFP_KERNEL, fwctx, 5ff013914c62c4 drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c Linus Walleij 2021-07-12 705 brcmf_fw_request_done); 5ff013914c62c4 drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c Linus Walleij 2021-07-12 706 kfree(alt_path); 5ff013914c62c4 drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c Linus Walleij 2021-07-12 707 } 5ff013914c62c4 drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c Linus Walleij 2021-07-12 708 /* Else try canonical path */ 5ff013914c62c4 drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c Linus Walleij 2021-07-12 @709 if (ret) { 5b587496dc6359 drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c Hans de Goede 2018-10-10 710 ret = request_firmware_nowait(THIS_MODULE, true, first->path, 5b587496dc6359 drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c Hans de Goede 2018-10-10 711 fwctx->dev, GFP_KERNEL, fwctx, 5b587496dc6359 drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c Hans de Goede 2018-10-10 712 brcmf_fw_request_done); 5ff013914c62c4 drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c Linus Walleij 2021-07-12 713 } 5b587496dc6359 drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c Hans de Goede 2018-10-10 714 if (ret < 0) 5b587496dc6359 drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c Hans de Goede 2018-10-10 715 brcmf_fw_request_done(NULL, fwctx); 5b587496dc6359 drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c Hans de Goede 2018-10-10 716 d09ae51a4b6761 drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c Arend Van Spriel 2018-03-22 717 return 0; c43655345234ac drivers/net/wireless/brcm80211/brcmfmac/firmware.c Hante Meuleman 2015-04-14 718 } c43655345234ac drivers/net/wireless/brcm80211/brcmfmac/firmware.c Hante Meuleman 2015-04-14 719 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected]
.config.gz
Description: application/gzip
_______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
