CC: [email protected] In-Reply-To: <[email protected]> References: <[email protected]> TO: Dipen Patel <[email protected]>
Hi Dipen, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on 07f8c60fe60f84977dc815ec8a6b1100827c34dd] url: https://github.com/0day-ci/linux/commits/Dipen-Patel/Intro-to-Hardware-timestamping-engine/20220202-062447 base: 07f8c60fe60f84977dc815ec8a6b1100827c34dd :::::: branch date: 3 days ago :::::: commit date: 3 days ago config: i386-randconfig-m021-20220131 (https://download.01.org/0day-ci/archive/20220205/[email protected]/config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> Reported-by: Dan Carpenter <[email protected]> New smatch warnings: drivers/gpio/gpiolib-cdev.c:841 hte_edge_setup() error: uninitialized symbol 'flags'. Old smatch warnings: drivers/gpio/gpiolib-cdev.c:2023 lineevent_create() warn: 'irq' not released on lines: 2012. vim +/flags +841 drivers/gpio/gpiolib-cdev.c 65cff70464068a Kent Gibson 2020-09-28 828 09c0523049e7be Dipen Patel 2022-02-01 829 static int hte_edge_setup(struct line *line, u64 eflags) 09c0523049e7be Dipen Patel 2022-02-01 830 { 09c0523049e7be Dipen Patel 2022-02-01 831 unsigned long flags; 09c0523049e7be Dipen Patel 2022-02-01 832 struct hte_ts_desc *hdesc = &line->hdesc; 09c0523049e7be Dipen Patel 2022-02-01 833 09c0523049e7be Dipen Patel 2022-02-01 834 if (eflags & GPIO_V2_LINE_FLAG_EDGE_RISING) 09c0523049e7be Dipen Patel 2022-02-01 835 flags |= test_bit(FLAG_ACTIVE_LOW, &line->desc->flags) ? 09c0523049e7be Dipen Patel 2022-02-01 836 HTE_FALLING_EDGE_TS : HTE_RISING_EDGE_TS; 09c0523049e7be Dipen Patel 2022-02-01 837 if (eflags & GPIO_V2_LINE_FLAG_EDGE_FALLING) 09c0523049e7be Dipen Patel 2022-02-01 838 flags |= test_bit(FLAG_ACTIVE_LOW, &line->desc->flags) ? 09c0523049e7be Dipen Patel 2022-02-01 839 HTE_RISING_EDGE_TS : HTE_FALLING_EDGE_TS; 09c0523049e7be Dipen Patel 2022-02-01 840 09c0523049e7be Dipen Patel 2022-02-01 @841 hdesc->attr.edge_flags = flags; 09c0523049e7be Dipen Patel 2022-02-01 842 hdesc->attr.line_data = line->desc; 09c0523049e7be Dipen Patel 2022-02-01 843 hdesc->attr.line_id = desc_to_gpio(line->desc); 09c0523049e7be Dipen Patel 2022-02-01 844 line->total_discard_seq = 0; 09c0523049e7be Dipen Patel 2022-02-01 845 09c0523049e7be Dipen Patel 2022-02-01 846 return hte_req_ts_by_linedata_ns(hdesc, process_hw_ts, 09c0523049e7be Dipen Patel 2022-02-01 847 process_hw_ts_thread, line); 09c0523049e7be Dipen Patel 2022-02-01 848 } 09c0523049e7be Dipen Patel 2022-02-01 849 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected] _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
