CC: [email protected]
BCC: [email protected]
In-Reply-To: <[email protected]>
References: <[email protected]>
TO: Namjae Jeon <[email protected]>
TO: [email protected]
TO: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: Al Viro <[email protected]>
CC: Namjae Jeon <[email protected]>

Hi Namjae,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v5.18-rc4 next-20220428]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    
https://github.com/intel-lab-lkp/linux/commits/Namjae-Jeon/ksmbd-remove-internal-h-include/20220427-103452
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 
46cf2c613f4b10eb12f749207b0fd2c1bfae3088
:::::: branch date: 2 days ago
:::::: commit date: 2 days ago
config: x86_64-randconfig-m001-20220425 
(https://download.01.org/0day-ci/archive/20220429/[email protected]/config)
compiler: gcc-11 (Debian 11.2.0-20) 11.2.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>
Reported-by: Dan Carpenter <[email protected]>

New smatch warnings:
fs/namei.c:3011 lock_rename_child() warn: inconsistent returns 
'&c1->d_sb->s_vfs_rename_mutex'.

Old smatch warnings:
fs/namei.c:1577 lookup_dcache() warn: passing zero to 'ERR_PTR'
fs/namei.c:1674 lookup_fast() warn: passing zero to 'ERR_PTR'
fs/namei.c:2202 hash_name() error: uninitialized symbol 'bdata'.
fs/namei.c:3447 open_last_lookups() error: uninitialized symbol 'inode'.
fs/namei.c:3447 open_last_lookups() error: uninitialized symbol 'seq'.

vim +3011 fs/namei.c

^1da177e4c3f41 Linus Torvalds 2005-04-16  2994  
ff7e30da72593b Al Viro        2022-04-27  2995  struct dentry 
*lock_rename_child(struct dentry *c1, struct dentry *p2)
ff7e30da72593b Al Viro        2022-04-27  2996  {
ff7e30da72593b Al Viro        2022-04-27  2997          if 
(READ_ONCE(c1->d_parent) == p2) {
ff7e30da72593b Al Viro        2022-04-27  2998                  
inode_lock_nested(p2->d_inode, I_MUTEX_PARENT);
ff7e30da72593b Al Viro        2022-04-27  2999                  if 
(likely(c1->d_parent == p2))
ff7e30da72593b Al Viro        2022-04-27  3000                          return 
NULL;
ff7e30da72593b Al Viro        2022-04-27  3001  
ff7e30da72593b Al Viro        2022-04-27  3002                  
inode_unlock(p2->d_inode);
ff7e30da72593b Al Viro        2022-04-27  3003          }
ff7e30da72593b Al Viro        2022-04-27  3004  
ff7e30da72593b Al Viro        2022-04-27  3005          
mutex_lock(&c1->d_sb->s_vfs_rename_mutex);
ff7e30da72593b Al Viro        2022-04-27  3006          if (likely(c1->d_parent 
!= p2))
ff7e30da72593b Al Viro        2022-04-27  3007                  return 
lock_two_directories(c1->d_parent, p2);
ff7e30da72593b Al Viro        2022-04-27  3008  
ff7e30da72593b Al Viro        2022-04-27  3009          
inode_lock_nested(p2->d_inode, I_MUTEX_PARENT);
ff7e30da72593b Al Viro        2022-04-27  3010          
mutex_unlock(&c1->d_sb->s_vfs_rename_mutex);
ff7e30da72593b Al Viro        2022-04-27 @3011          return NULL;
ff7e30da72593b Al Viro        2022-04-27  3012  }
ff7e30da72593b Al Viro        2022-04-27  3013  
EXPORT_SYMBOL(lock_rename_child);
ff7e30da72593b Al Viro        2022-04-27  3014  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp
_______________________________________________
kbuild mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to