CC: [email protected] BCC: [email protected] In-Reply-To: <[email protected]> References: <[email protected]> TO: Nitesh Shetty <[email protected]> CC: [email protected] CC: [email protected] CC: [email protected] CC: [email protected] CC: [email protected] CC: [email protected] CC: [email protected] CC: [email protected] CC: [email protected] CC: [email protected] CC: [email protected] CC: [email protected] CC: [email protected] CC: [email protected] CC: [email protected] CC: [email protected] CC: [email protected] CC: [email protected] CC: [email protected] CC: [email protected] CC: [email protected] CC: [email protected] CC: [email protected] CC: [email protected] CC: Nitesh Shetty <[email protected]> CC: Arnav Dawn <[email protected]> CC: Alasdair Kergon <[email protected]> CC: Mike Snitzer <[email protected]> CC: Sagi Grimberg <[email protected]> CC: James Smart <[email protected]>
Hi Nitesh, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on next-20220422] [cannot apply to axboe-block/for-next device-mapper-dm/for-next linus/master v5.18-rc4 v5.18-rc3 v5.18-rc2 v5.18-rc4] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Nitesh-Shetty/block-Introduce-queue-limits-for-copy-offload-support/20220426-201825 base: e7d6987e09a328d4a949701db40ef63fbb970670 :::::: branch date: 3 days ago :::::: commit date: 3 days ago compiler: arm-linux-gnueabi-gcc (GCC) 11.3.0 reproduce (cppcheck warning): # apt-get install cppcheck git checkout 3e91cba65ef73ba116953031d5548da7fd33a150 cppcheck --quiet --enable=style,performance,portability --template=gcc FILE If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> cppcheck possible warnings: (new ones prefixed by >>, may not real problems) >> block/blk-lib.c:341:6: warning: Redundant initialization for 'ret'. The >> initialized value is overwritten before it is read. [redundantInitialization] ret = blk_copy_sanity_check(src_bdev, dest_bdev, rlist, nr); ^ block/blk-lib.c:327:10: note: ret is initialized int ret = -EINVAL; ^ block/blk-lib.c:341:6: note: ret is overwritten ret = blk_copy_sanity_check(src_bdev, dest_bdev, rlist, nr); ^ vim +/ret +341 block/blk-lib.c 3e91cba65ef73b Nitesh Shetty 2022-04-26 309 3e91cba65ef73b Nitesh Shetty 2022-04-26 310 /* 3e91cba65ef73b Nitesh Shetty 2022-04-26 311 * blkdev_issue_copy - queue a copy 3e91cba65ef73b Nitesh Shetty 2022-04-26 312 * @src_bdev: source block device 3e91cba65ef73b Nitesh Shetty 2022-04-26 313 * @nr_srcs: number of source ranges to copy 3e91cba65ef73b Nitesh Shetty 2022-04-26 314 * @rlist: array of source/dest/len 3e91cba65ef73b Nitesh Shetty 2022-04-26 315 * @dest_bdev: destination block device 3e91cba65ef73b Nitesh Shetty 2022-04-26 316 * @gfp_mask: memory allocation flags (for bio_alloc) 3e91cba65ef73b Nitesh Shetty 2022-04-26 317 * 3e91cba65ef73b Nitesh Shetty 2022-04-26 318 * Description: 3e91cba65ef73b Nitesh Shetty 2022-04-26 319 * Copy source ranges from source block device to destination block device. 3e91cba65ef73b Nitesh Shetty 2022-04-26 320 * length of a source range cannot be zero. 3e91cba65ef73b Nitesh Shetty 2022-04-26 321 */ 3e91cba65ef73b Nitesh Shetty 2022-04-26 322 int blkdev_issue_copy(struct block_device *src_bdev, int nr, 3e91cba65ef73b Nitesh Shetty 2022-04-26 323 struct range_entry *rlist, struct block_device *dest_bdev, gfp_t gfp_mask) 3e91cba65ef73b Nitesh Shetty 2022-04-26 324 { 3e91cba65ef73b Nitesh Shetty 2022-04-26 325 struct request_queue *src_q = bdev_get_queue(src_bdev); 3e91cba65ef73b Nitesh Shetty 2022-04-26 326 struct request_queue *dest_q = bdev_get_queue(dest_bdev); 3e91cba65ef73b Nitesh Shetty 2022-04-26 327 int ret = -EINVAL; 3e91cba65ef73b Nitesh Shetty 2022-04-26 328 3e91cba65ef73b Nitesh Shetty 2022-04-26 329 if (!src_q || !dest_q) 3e91cba65ef73b Nitesh Shetty 2022-04-26 330 return -ENXIO; 3e91cba65ef73b Nitesh Shetty 2022-04-26 331 3e91cba65ef73b Nitesh Shetty 2022-04-26 332 if (!nr) 3e91cba65ef73b Nitesh Shetty 2022-04-26 333 return -EINVAL; 3e91cba65ef73b Nitesh Shetty 2022-04-26 334 3e91cba65ef73b Nitesh Shetty 2022-04-26 335 if (nr >= MAX_COPY_NR_RANGE) 3e91cba65ef73b Nitesh Shetty 2022-04-26 336 return -EINVAL; 3e91cba65ef73b Nitesh Shetty 2022-04-26 337 3e91cba65ef73b Nitesh Shetty 2022-04-26 338 if (bdev_read_only(dest_bdev)) 3e91cba65ef73b Nitesh Shetty 2022-04-26 339 return -EPERM; 3e91cba65ef73b Nitesh Shetty 2022-04-26 340 3e91cba65ef73b Nitesh Shetty 2022-04-26 @341 ret = blk_copy_sanity_check(src_bdev, dest_bdev, rlist, nr); 3e91cba65ef73b Nitesh Shetty 2022-04-26 342 if (ret) 3e91cba65ef73b Nitesh Shetty 2022-04-26 343 return ret; 3e91cba65ef73b Nitesh Shetty 2022-04-26 344 3e91cba65ef73b Nitesh Shetty 2022-04-26 345 if (blk_check_copy_offload(src_q, dest_q)) 3e91cba65ef73b Nitesh Shetty 2022-04-26 346 ret = blk_copy_offload(src_bdev, nr, rlist, dest_bdev, gfp_mask); 3e91cba65ef73b Nitesh Shetty 2022-04-26 347 3e91cba65ef73b Nitesh Shetty 2022-04-26 348 return ret; 3e91cba65ef73b Nitesh Shetty 2022-04-26 349 } 3e91cba65ef73b Nitesh Shetty 2022-04-26 350 EXPORT_SYMBOL_GPL(blkdev_issue_copy); 3e91cba65ef73b Nitesh Shetty 2022-04-26 351 -- 0-DAY CI Kernel Test Service https://01.org/lkp _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
