On Tue, 20 Jan 2004 11:13:32 +0530, 
Prashanth T <[EMAIL PROTECTED]> wrote:
prasht> Jim,   I had tried this earlier, taking COMMON code
prasht> kdb-4.3-2.6.0-test11-common1.patch  (by Keith) and i386 code from
prasht> your code on linux 2.6.0.   I had encountered the same two problems
prasht> which you have mentioned and the fixes rightly said by you,are in
prasht> COMMON code itself.  Attached below is the patch for those two
prasht> issues to be made to the  COMMON code: 
prasht> Correct me if I am wrong.

prasht> 1.  local_bh_enable( ) is to be replaced with __local_bh_enable( ) since
prasht>      in an SMP environment, all CPUs other than the intial CPU would
prasht>      have their IRQs disabled.   Because of this, they would dump
prasht>      their stack when they encounter the WARN_ON check in
prasht>      local_bh_enable( ) code. 

That suppresses the warning message, but does not fix the underlying
problem.  kdb is enabling interrupts too soon which can lead to
deadlock.  Work in progress to fix this.

prasht> 2.  I think tasklist_lock comes into picture only in case of SMP and
prasht>      to check if this lock is acquired by any other process,
prasht>      rwlock_is_locked( ) routine is to be used.

Applied, thanks.

JH> I have updated my patch for kdb for i386 on linux-2.6.  It is
JH> available here:
JH> 
JH>     http://www.ccur.com/isd_oss.asp

Thanks Jim, pulled into my WIP, release "soon".

Use http://oss.sgi.com/ecartis to modify your settings or to unsubscribe.

Reply via email to