https://bugs.kde.org/show_bug.cgi?id=505985
Jack Hill <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Latest Commit| |https://invent.kde.org/mult | |imedia/elisa/-/commit/89c0f | |c4ac0ae643cc493f31a72ef8909 | |30adda16 Status|ASSIGNED |RESOLVED --- Comment #3 from Jack Hill <[email protected]> --- Git commit 89c0fc4ac0ae643cc493f31a72ef890930adda16 by Jack Hill. Committed on 05/07/2025 at 19:31. Pushed by jackh into branch 'master'. Remove unneeded cover file cache in file listing This is unneeded and buggy for the following reasons: 1. It was only storing external cover files 2. These cover files are already cached on a directory basis in filescanner 3. The file url was used as the key, but the search for the cached cover was using the album title as the key 4. Even if we started using the album title as the key, it is possible for separate albums to have the same title 5. We wouldn't want to cache by track url either because this would mean the database wouldn't update if the cover file was modified Test-plan: Tested manually by copying a music file into a folder that already contained an image file. Previously Elisa would use the external image file regardless of whether the music file had an embedded cover. Now Elisa uses the embedded cover. M +0 -32 autotests/localfilelistingtest.cpp M +8 -2 src/abstractfile/abstractfilelistener.cpp M +3 -17 src/abstractfile/abstractfilelisting.cpp M +2 -4 src/abstractfile/abstractfilelisting.h M +1 -3 src/android/androidfilelisting.cpp M +5 -0 src/databaseinterface.h M +1 -3 src/file/localfilelisting.cpp M +1 -0 src/filescanner.cpp M +3 -3 src/modeldataloader.cpp M +2 -2 src/modeldataloader.h M +1 -1 src/models/editabletrackmetadatamodel.cpp M +1 -1 src/models/editabletrackmetadatamodel.h https://invent.kde.org/multimedia/elisa/-/commit/89c0fc4ac0ae643cc493f31a72ef890930adda16 -- You are receiving this mail because: You are watching all bug changes.
