https://bugs.kde.org/show_bug.cgi?id=514297

--- Comment #24 from Mark Wielaard <[email protected]> ---
Hi Martin,

(In reply to mcermak from comment #23)
> Created attachment 190530 [details]
> proposed patch
> 
> Updated patch trying to address all the review comments above.  I've also
> checked this update to a topic branch users/mcermak/try-bug514297 and got
> buildbot test results for it:
> 
> https://builder.sourceware.org/buildbot/#/builders/244/builds/139

Nice, Thanks. Note the following warnings on powerpc (but not x86_64):

m_syswrap/syswrap-generic.c:2424:22: warning: self-comparison always evaluates
to false [-Wtautological-compare]
m_syswrap/syswrap-generic.c:2429:25: warning: self-comparison always evaluates
to false [-Wtautological-compare]
m_aspacemgr/aspacemgr-linux.c:1128:13: warning: function declaration isn’t a
prototype [-Wstrict-prototypes]
m_aspacemgr/aspacemgr-linux.c:3054:20: warning: self-comparison always
evaluates to false [-Wtautological-compare]
m_aspacemgr/aspacemgr-linux.c:3063:20: warning: self-comparison always
evaluates to false [-Wtautological-compare]

I haven't investigated why. And these might not even be in your new code. If it
doesn't make sense, just ignore.

make regtest seems to have a lot more failures than I am getting locally. But
this is not specific to your try run.
It looks like in general the buildbot has a lot more failures (a lot of extra
inherited leaked file descriptors?) . Very odd.

What are the make regtest results locally? I am getting (with current git trunk
on x86_64 fedora 43):

== 963 tests, 0 stderr failures, 0 stdout failures, 0 stderrB failures, 1
stdoutB failure, 0 post failures ==
gdbserver_tests/hgtls                    (stdoutB)

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to