https://bugs.kde.org/show_bug.cgi?id=514297
--- Comment #27 from Mark Wielaard <[email protected]> --- (In reply to mcermak from comment #23) > > It would be better if cl_pagemap_fd was only defined/used in > > coregrind/m_aspacemgr/aspacemgr-linux.c You could set it up in > > VG_(am_startup). I think we should avoid that ../pub_core_clientstate.h > > include. > > Done. To make it work I had to move setup_file_descriptors() towards the > beginning of valgrind_main(), before the address space manager is > initialized. Without that VG_(safe_fd)() would fail the > vg_assert(VG_(fd_hard_limit) != -1); Nice. Could you move the move the pub_core_libcfile.h include into priv_aspacemgr.h (There is a big comment block just before that saying new includes should move there.) -- You are receiving this mail because: You are watching all bug changes.
