https://bugs.kde.org/show_bug.cgi?id=387080
Mark Wielaard <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] Ever confirmed|0 |1 Status|REPORTED |ASSIGNED --- Comment #5 from Mark Wielaard <[email protected]> --- (In reply to jgfloyd229 from comment #4) > Created attachment 192650 [details] > adds peak-only option do ms_print > > I added tests and documentation for the option peak-only. - Please remove the second [PATCH] in the commit Subject. - Could you add a little bit more comment to the commit message, just describing what changed? - Add this bug (number) as a NEWS file entry. > diff --git a/massif/docs/ms-manual.xml b/massif/docs/ms-manual.xml > index 22941fa522b5..5ca6974a329c 100644 > --- a/massif/docs/ms-manual.xml > +++ b/massif/docs/ms-manual.xml > @@ -279,6 +279,9 @@ consumption was greatest. The peak snapshot is > represented in the graph by > a bar consisting of '#' characters. The text at the bottom shows > that snapshot 14 was the peak.</para> > > +<para> The option <option>--peak-only </option> can be used to get the peak > +memory consumption and nothing else.</para> > + Nitpick. Stray whitespace after --preak-only and before </option>. > @@ -836,6 +839,16 @@ various places online. > will run drastically slower as the number approaches zero.</para> > </listitem> > </varlistentry> > + Another nitpick, stray whitespace on empty line. massif/ms_print.in changes look good. massif/tests/Makefile.am likewise. > diff --git a/massif/tests/peak_only.post.exp b/massif/tests/peak_only.post.exp > new file mode 100644 > index 000000000000..ec6293ef916e > --- /dev/null > +++ b/massif/tests/peak_only.post.exp > @@ -0,0 +1 @@ > +Peak memory usage: 34704 bytes This works locally for me. But are you sure this works on all setups? Maybe you need a filter the turn that number into xxxx or something? massif/tests/peak_only.vgtest I didn't know you could provide multiple vgopts arguments. This looks like it was copy/pasted from another massif vgtest file? (I don't know the macos port well enough, but it looks similar to others) The actual check is in post and looks good. -- You are receiving this mail because: You are watching all bug changes.
