https://bugs.kde.org/show_bug.cgi?id=387080

--- Comment #6 from [email protected] ---
(In reply to Mark Wielaard from comment #5)
> - Please remove the second [PATCH] in the commit Subject.
> - Could you add a little bit more comment to the commit message, just
> describing what changed?
> - Add this bug (number) as a NEWS file entry.

I will do it as well as the nitpicks.

> This works locally for me.
> But are you sure this works on all setups?

it works on linux and freeBSD amd64. I will test it on 32bit.

> massif/tests/peak_only.vgtest
> I didn't know you could provide multiple vgopts arguments.
> This looks like it was copy/pasted from another massif vgtest file?

It was indeed copied from the peak test.

> (I don't know the macos port well enough, but it looks similar to others)
> The actual check is in post and looks good.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to