https://bugs.kde.org/show_bug.cgi?id=467328

William Wojciechowski <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]

--- Comment #20 from William Wojciechowski <[email protected]> ---
Re comment #19: not a regression. The 6d2dec6324ca09cc254b7102f197748238f7645e
fix still works, but its condition is off by default, so almost nobody reaches
it: it only applies when annotations are not being printed.

The checkbox "Print annotations" is buried behind Print dialog → "Options >>" →
"PDF Options" tab, which makes it unlikely to be found by accident.

generator_pdf.cpp gates it on !printAnnots, while PDFOptionsPage does
setPrintAnnots(true); // Default value.

There is no kcfg entry for it, so the choice cannot be persisted: the box is
back on at every print. Documents with no annotation at all still go through
PSConverter.

Verifiable in two prints with the queue paused:

    checked   → document-name-supplied = okular_XXXXXX.ps
    unchecked → document-name-supplied = <the original>.pdf

The detour is not harmless: CUPS' gstopdf runs `gs -sDEVICE=pdfwrite`, which
converts the text to outlines — `pdffonts` reports no font at all in the
intermediate PDF. Unhinted glyphs then grow ~2 px at 300 dpi, enough to close a
0.48 pt underline clearance completely. Okular's own PostScript is not at
fault: its Type42 fonts keep their cvt/fpgm/prep tables.

Three independent changes, which could well be applied together:

* give the checkbox a kcfg entry so the choice persists, as PrintScaleMode
already does;
* ignore it, or grey it out, when the document carries no annotation — walking
document()->page(i)->annotations(), using Okular's model rather than Poppler's
so that unsaved in-session annotations still force the PS path;
* default it to false. This is the only one of the three with a visible
behaviour change: annotated documents would then print without their
annotations unless the user opts back in.

Operating System: Debian GNU/Linux forky/sid
Kernel Version: 7.2.6+deb14-amd64 (64-bit)
KDE Plasma Version: 6.7.4
KDE Frameworks Version: 6.30.0
Qt Version: 6.10.2
Okular: 26.08.0
Print stack: CUPS 2.4.18, cups-filters 1.28.17, Ghostscript 10.07.1, Poppler
26.07.0

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to