https://bugs.kde.org/show_bug.cgi?id=475448
Dmitry Kazakov <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Latest Commit| |https://invent.kde.org/grap | |hics/krita/-/commit/1e79bbd | |698a76f72119dfe4ea27abece20 | |f85f33 Resolution|--- |FIXED --- Comment #7 from Dmitry Kazakov <[email protected]> --- Git commit 1e79bbd698a76f72119dfe4ea27abece20f85f33 by Dmitry Kazakov. Committed on 21/10/2026 at 10:35. Pushed by dkazakov into branch 'master'. Refactor KoToolManager to belong to KisViewManager It is a really bad idea to have the tool manager as a singleton, since it activates the tool before all other managers completed the switching. M +24 -1 libs/flake/KoCanvasController.cpp M +9 -0 libs/flake/KoCanvasController.h M +29 -2 libs/flake/KoSelection.cpp M +1 -1 libs/flake/KoSelection.h M +23 -7 libs/flake/KoSelection_p.h M +3 -0 libs/flake/KoShape.cpp M +2 -1 libs/flake/KoShape.h M +1 -6 libs/flake/KoShapeController.cpp M +0 -11 libs/flake/KoShapeController.h M +2 -1 libs/flake/KoShapeControllerBase.cpp M +2 -1 libs/flake/KoShapeControllerBase.h M +7 -12 libs/flake/KoToolFactoryBase.cpp M +3 -6 libs/flake/KoToolFactoryBase.h M +48 -89 libs/flake/KoToolManager.cpp M +15 -23 libs/flake/KoToolManager.h M +4 -2 libs/flake/KoToolManager_p.cpp M +0 -10 libs/flake/KoToolManager_p.h M +4 -6 libs/flake/KoToolProxy.cpp M +2 -1 libs/flake/tools/KoPathTool.cpp M +3 -1 libs/flake/tools/KoPathToolFactory.cpp M +1 -1 libs/flake/tools/KoPathToolFactory.h M +5 -5 libs/ui/KisMainWindow.cpp M +10 -7 libs/ui/KisView.cpp M +22 -11 libs/ui/KisViewManager.cpp M +1 -0 libs/ui/KisViewManager.h M +3 -3 libs/ui/actions/KisPasteActionFactories.cpp M +0 -34 libs/ui/flake/kis_node_shape.cpp M +9 -6 libs/ui/flake/kis_shape_controller.cpp M +2 -1 libs/ui/flake/kis_shape_controller.h M +7 -9 libs/ui/input/kis_input_manager.cpp M +2 -1 libs/ui/input/kis_input_manager.h M +2 -1 libs/ui/input/kis_input_manager_p.cpp M +4 -1 libs/ui/input/kis_input_manager_p.h M +3 -2 libs/ui/input/kis_tool_invocation_action.cpp M +10 -5 libs/ui/kis_node_manager.cpp M +5 -6 libs/ui/kis_paintop_box.cc M +2 -2 libs/ui/kis_selection_manager.cc M +1 -1 libs/ui/kis_statusbar.cc M +0 -2 libs/ui/kis_zoom_manager.cc M +4 -3 libs/ui/tests/kis_view_signals_test.cpp M +4 -4 libs/ui/tool/KisSelectionToolFactoryBase.cpp M +2 -2 libs/ui/tool/KisSelectionToolFactoryBase.h M +3 -1 libs/ui/tool/KisToolPaintFactoryBase.cpp M +1 -1 libs/ui/tool/KisToolPaintFactoryBase.h M +24 -22 libs/ui/toolbox/KoToolBox.cpp M +1 -0 libs/ui/widgets/kis_tool_options_popup.cpp M +0 -9 libs/widgets/KoRuler.cpp M +0 -8 libs/widgets/KoRuler.h M +1 -0 libs/widgets/KoToolDocker.cpp M +10 -3 plugins/paintops/mypaint/MyPaintPaintOp.cpp M +2 -2 plugins/tools/basictools/kis_tool_brush.cc M +1 -1 plugins/tools/basictools/kis_tool_brush.h M +2 -2 plugins/tools/basictools/kis_tool_move.cc M +1 -1 plugins/tools/basictools/kis_tool_move.h M +2 -2 plugins/tools/basictools/kis_tool_pan.cpp M +1 -1 plugins/tools/basictools/kis_tool_pan.h M +6 -3 plugins/tools/defaulttool/defaulttool/DefaultTool.cpp M +3 -1 plugins/tools/defaulttool/defaulttool/DefaultToolFactory.cpp M +1 -1 plugins/tools/defaulttool/defaulttool/DefaultToolFactory.h M +2 -2 plugins/tools/defaulttool/referenceimagestool/ToolReferenceImages.cpp M +1 -1 plugins/tools/defaulttool/referenceimagestool/ToolReferenceImages.h M +3 -1 plugins/tools/karbonplugins/tools/CalligraphyTool/KarbonCalligraphyToolFactory.cpp M +1 -1 plugins/tools/karbonplugins/tools/CalligraphyTool/KarbonCalligraphyToolFactory.h M +2 -2 plugins/tools/selectiontools/KisToolSelectMagnetic.h M +2 -2 plugins/tools/selectiontools/kis_tool_select_polygonal.h M +1 -1 plugins/tools/svgtexttool/SvgCreateTextStrategy.cpp M +2 -1 plugins/tools/svgtexttool/SvgTextTool.cpp M +3 -1 plugins/tools/svgtexttool/SvgTextToolFactory.cpp M +1 -1 plugins/tools/svgtexttool/SvgTextToolFactory.h M +21 -37 plugins/tools/tool_transform2/kis_tool_transform.cc M +2 -10 plugins/tools/tool_transform2/kis_tool_transform.h https://invent.kde.org/graphics/krita/-/commit/1e79bbd698a76f72119dfe4ea27abece20f85f33 -- You are receiving this mail because: You are watching all bug changes.
