https://bugs.kde.org/show_bug.cgi?id=525749

--- Comment #4 from Craig Rutherford <[email protected]> ---
Steps to reproduce:
1. Assign shortcuts to two service menu actions in Configure Keyboard Shortcuts
(Context Menu Actions). Both work.
2. Open Settings > Configure Dolphin > Context Menu, untick one service, click
Apply. This writes ~/.config/kservicemenurc.
3. Press the shortcut of the OTHER action, which is still enabled.

Result: the shortcut no longer works, and the shortcuts dialog shows its field
blank. Its line is still in ~/.local/share/kxmlgui5/dolphin/dolphinui.rc the
whole time. Restarting Dolphin brings it back.

I think this is what users are seeing as shortcuts disappearing "at random"
(see bug 525749, which reports the same loss), since the rebuild can also be
triggered by unrelated config changes.

Cause, from reading the source: in 26.08.1,
ServiceMenuShortcutManager::refresh() registers new actions without carrying
the old shortcuts over, and nothing re-reads dolphinui.rc afterward. The
watcher on kservicemenurc is also created with globals, so it fires on
unrelated changes.

Both problems are fixed on master:
- d90c6f46 "shortcutmanager: keep user shortcuts across refreshes"
- ec0786da "Rebuild the file item actions on service menu changes alone"
Neither is in v26.08.1, v26.08.2 or the release/26.08 branch as far as I can
see. Could they be backported?

Caveat: an earlier attempt where I unticked a different service did not drop my
shortcuts, and I don't know why.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to