David Edmundson <> changed:

           What    |Removed                     |Added
         Resolution|---                         |FIXED
             Status|CONFIRMED                   |RESOLVED
      Latest Commit|                            |
                   |                            |/371e523f5d7ee0e37934135db6
                   |                            |499eff3b976162

--- Comment #5 from David Edmundson <> ---
Git commit 371e523f5d7ee0e37934135db6499eff3b976162 by David Edmundson.
Committed on 12/04/2018 at 20:35.
Pushed by davidedmundson into branch 'master'.

Correctly encode URL of thumbnails

As per the amazingly detailed bug report, the spec says URLs should be
percent encoded. The main knock-on effect is we get a different hash
value for our preview file and we duplicate thumbnails if a user uses a
GNOME app.

Test Plan:
Logged out and back in
Copied jpeg to a file with spaces
opened dolphin
Found relevant cache file in ~/.cache/thumbnails/normal based on timestamp
exiftool showed the correct URI.

Thumb URI                       : file:///tmp/with%20spaces.jpg

I assume the hash is now "correct" but I don't have a way to check

Reviewers: ngraham

Reviewed By: ngraham

Subscribers: ngraham, #frameworks

Tags: #frameworks

Differential Revision:

M  +4    -4    src/widgets/previewjob.cpp

You are receiving this mail because:
You are watching all bug changes.

Reply via email to