https://bugs.kde.org/show_bug.cgi?id=393255
--- Comment #10 from Maximiliano Curia <[email protected]> --- (In reply to mbiebl from comment #9) > (In reply to Maximiliano Curia from comment #8) > > Well kdelibs4support is a porting aid, a library that provides some > > interfaces that were available in kde4 but are not part of kde frameworks 5 > > (they have a suitable replacement in the kf5 family but it might not always > > be trivial to migrate to), as such it's highly disrecommended to use it. So, > > I wouldn't bet on upstream fixing, or even accepting a patch to fix, > > something that was always broken. > To clarify: The build was broken in kdelibs4support, it is not broken in > kde-runtime. Yeah, the NM_0_7 define is present in kde-runtime. > > It might make more sense to drop the dead code (as long as it doesn't break > > any api). > I don't know KDE too well, so I don't know which KF5 programs still rely on > the functionality of the networkstatus kded module or if it's safe to drop > it. If you think dropping the functionality is the way to go, do you think > the same should be applied to kde-runtime? kde-runtime is no longer being maintained by kde.org, the repository is still available, but that's it, so the patch won't be applied upstream. On the Debian side, we don't really know if somebody uses the networkstatus kded module, a quick search in codesearch showed no results, but the idea is to drop kde-runtime (and qt4 for that matter) for buster, so disabling an optional feature should be fine. Anyway, you might want to forward this patch or the one that drops the use of network manager from kdelibs4support to the codereview system: https://phabricator.kde.org Upstream usually has a lower latency when a code review is requested. Happy hacking, -- You are receiving this mail because: You are watching all bug changes.
