https://bugs.kde.org/show_bug.cgi?id=396535
Nate Graham <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Version Fixed In| |5.51 Latest Commit| |https://commits.kde.org/bal | |oo/2452ce28193a7cf4843a8f61 | |7f3fe29c6643fd96 Resolution|--- |FIXED Status|ASSIGNED |RESOLVED --- Comment #5 from Nate Graham <[email protected]> --- Git commit 2452ce28193a7cf4843a8f617f3fe29c6643fd96 by Nathaniel Graham. Committed on 30/09/2018 at 01:17. Pushed by ngraham into branch 'master'. [Balooctl] remove directory parent check Summary: `balooctl add includeFolders/excludeFolders` was checking for parent directories before allowing the user to add a subdirectory. This is unnecessary since Baloo itself supports the logic of (for example) excluding `~/foo` but including `~/foo/bar`. Removing the check solves the problem and fixes 396535. FIXED-IN: 5.51 Test Plan: ``` mkdir ~/test1 ~/test2 ~/test1-test ~/test1-test/foo balooctl config add excludeFolders ~/test1 balooctl config add excludeFolders ~/test2 balooctl config add excludeFolders ~/test1-test balooctl config add includeFolders ~/test1-test/foo ``` If it worked, you don't get any errors. Reviewers: #baloo, #dolphin, bruns, #frameworks, cfeck Reviewed By: #baloo, bruns Subscribers: smithjd, anthonyfieroni, kde-frameworks-devel Tags: #frameworks, #baloo Differential Revision: https://phabricator.kde.org/D15583 M +0 -14 src/tools/balooctl/configcommand.cpp https://commits.kde.org/baloo/2452ce28193a7cf4843a8f617f3fe29c6643fd96 -- You are receiving this mail because: You are watching all bug changes.
