https://bugs.kde.org/show_bug.cgi?id=357960
Stefan Brüns <stefan.bru...@rwth-aachen.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|CONFIRMED |RESOLVED
Latest Commit| |https://commits.kde.org/bal
| |oo/e1045c4f7891e012e03caf9b
| |1f5a5c81c585e282
--- Comment #9 from Stefan Brüns <stefan.bru...@rwth-aachen.de> ---
Git commit e1045c4f7891e012e03caf9b1f5a5c81c585e282 by Stefan Brüns.
Committed on 01/12/2018 at 13:48.
Pushed by bruns into branch 'master'.
Fix searches for rating 10 (5 stars)
Summary:
The comparator callback/lambda used a string comparision, which returned
the wrong documents, as "2" > "10", and "10" < "9", i.e. selecting the
"Highest rating" in dolphin returned all documents with a rating of 2
or higher.
Convert the numeric suffix of the rating term ("R2", "R10", ...) to
an integer value and use it for comparision.
Reviewers: #baloo, #frameworks, ngraham, poboiko, mgallien
Reviewed By: #baloo, ngraham
Subscribers: kde-frameworks-devel
Tags: #frameworks, #baloo
Differential Revision: https://phabricator.kde.org/D17272
M +2 -2 autotests/unit/engine/postingdbtest.cpp
M +5 -5 src/engine/postingdb.cpp
M +1 -1 src/engine/postingdb.h
M +1 -1 src/engine/transaction.cpp
M +1 -1 src/engine/transaction.h
M +3 -4 src/lib/searchstore.cpp
https://commits.kde.org/baloo/e1045c4f7891e012e03caf9b1f5a5c81c585e282
--
You are receiving this mail because:
You are watching all bug changes.
