https://bugs.kde.org/show_bug.cgi?id=118533

--- Comment #10 from [email protected] ---
>From your last patch :

- Why you touch InsertTextWidget implementation to just store a Boolean which
is never used ?
- a slot method must take "slot" prefix.
- always put a space to separate function argument, for better readability.
- No Java or Javascript coding style, It's C++ here. A bracket "{" must be
preceded by a CR. Whe have enough space, no need pseudo source compression.
Code must be easy to read.
- Please look the HACKING file from DK root directory for coding style to
follow. This point is VERY important. All the source code must have the same
coding style for maintenance. I pass a lot of time to polish code everywhere
these last year. I will refuse a patch which do not respect this rule.


Please update your patch and set all previous one as obsoletes in bugzilla.

Gilles Caulier

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to