https://bugs.kde.org/show_bug.cgi?id=118533
--- Comment #12 from Jay Singh Talreja <[email protected]> --- Created attachment 118251 --> https://bugs.kde.org/attachment.cgi?id=118251&action=edit Modified Patch ! (In reply to caulier.gilles from comment #10) > From your last patch : > > - Why you touch InsertTextWidget implementation to just store a Boolean > which is never used ? > - a slot method must take "slot" prefix. > - always put a space to separate function argument, for better readability. > - No Java or Javascript coding style, It's C++ here. A bracket "{" must be > preceded by a CR. Whe have enough space, no need pseudo source compression. > Code must be easy to read. > - Please look the HACKING file from DK root directory for coding style to > follow. This point is VERY important. All the source code must have the same > coding style for maintenance. I pass a lot of time to polish code everywhere > these last year. I will refuse a patch which do not respect this rule. > > > Please update your patch and set all previous one as obsoletes in bugzilla. > > Gilles Caulier i Looked over the coding style format and issues mentioned. -Formatted Code according to the conventional coding style . -Removed unnecessary Boolean parameter from the InsertTextWidget. Jay Singh -- You are receiving this mail because: You are watching all bug changes.
