https://bugs.kde.org/show_bug.cgi?id=360008
--- Comment #5 from Philippe Waroquiers <[email protected]> --- I (quickly) read the patch (did not test), a few minor comments/questions: * typo in power64-core.xml : typo: regect -> reject * powerpc-altivec64l-valgrind.xml : I am not sure to fully understand why we have 2 new includes for power64-core2-valgrind-s1.xml and power64-core2-valgrind-s1.xml, but there was no addition of power64-core2.xml after power-fpu.xml : normally, the s1 and s2 files should be similar in structure to the 'non shadow' register files. I see that the power64-core2*xml files are defining the shadow registers for e.g. pc/msr/cr while the equivalent non shadow registers are in power64-core.xml It is unclear to me why the shadow registers for these cannot be defined in files that are 'similar in structure' to the non shadow files. * valgrind-low-ppc64.c : typos fpmap -> fp map lower lower -> lower psuedo -> pseudo (twice this typo) remove final , after + { "vs31h", 10720, 64 }, * valgrind-low-ppc64.c : we have a bunch of lines that are (almost) duplicated for big/little endian. As far as I can see, the only difference is that the offset is [0] or [2]. So, if this is really the only difference, it would be better to use something like [offset] and have offset set to 0 or 2, depending on endianness. Thanks for looking at this -- You are receiving this mail because: You are watching all bug changes.
