https://bugs.kde.org/show_bug.cgi?id=408539

Christoph Cullmann <cullm...@kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REPORTED                    |RESOLVED
                 CC|                            |cullm...@kde.org
         Resolution|---                         |FIXED

--- Comment #1 from Christoph Cullmann <cullm...@kde.org> ---
Thanks for the report with usable backtrace, considering the line numbers, I
think this should be already fixed in master.

Please try with master, the fix should be:

commit e540262fb7230dfd40794d20c5d0e34dbc748b03
Author: Dāvis Mosāns <davis...@gmail.com>
Date:   Sat Mar 16 16:40:24 2019 +0100

    Don't crash on malformed syntax highlighting files

    Test Plan:
    1. Create malformed syntax highlighting file with missing end tags
    2. Place it in ~/.local/share/katepart5/syntax/
    3. Open Kate with file which uses that syntax highlighting

    Reviewers: cullmann, dhaumann

    Reviewed By: cullmann

    Subscribers: kwrite-devel, kde-frameworks-devel

    Tags: #kate, #frameworks

    Differential Revision: https://phabricator.kde.org/D19533

And no, the assert is correct.
If we arrive here with a invalid iterator, all is broken, this shall no happen.
We don't add early out for all cases of internal programming errors that shall
be fixed (and got fixed).

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to