https://bugs.kde.org/show_bug.cgi?id=433506

--- Comment #6 from Paul Floyd <pjfl...@wanadoo.fr> ---
(In reply to Mark Wielaard from comment #2)
> This patch makes cachegrind/tests/Makefile.am executable, which I think is
> wrong.

Done.

> In dhat/tests/copy.c, which test for && defined(__GNUC__)?
> Is mempcpy defined if __GNUC__ isn't on freebsd?

I think that it is not defined at all (it's nowhere in /usr/include), but clang
has it as a builtin.

> In none/tests/Makefile.am is it deliberate that resolv doesn't get any LDADD
> flags anymore (asking because res_search still does).

Looks like a copy/paste error. Fixed.

> In none/tests/amd64/Makefile.am why is the dependency on
> $(srcdir)/gen_insn_test.pl removed for the .def.c target?

It wasn't there for x86. I'll put it back and add it to x86.

> It is somewhat unfortunate we need
> none/tests/amd64/sse4-64.stdout.exp-freebsd-clang and
> none/tests/amd64/sse4-64.stdout.exp.freebsd, they are huge.

Huge and largely the same. Haven't spent time analyzing these small
differences, it just seems that each compiler/platform has to deviate a tiny
bit.

> There are a lot of extra none/tests/fdleak*exp.freebsd. It looks like
> freebsd doesn't provide the name of the file behind an fd. Is this a bug in
> the file descriptor leak checker on freebsd?

I just tried fdleak_open without the freebsd expected and it passes. I remember
spending some time debugging this and it seemed as though the KDE wm was
passing an open socket to processes to be able to tell when they exit (maybe, I
never realy understood what was happening).

I'll check the others and update as necessary.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to