https://bugs.kde.org/show_bug.cgi?id=433506

--- Comment #7 from Ed Maste <ema...@freebsd.org> ---
(In reply to Paul Floyd from comment #6)
> (In reply to Mark Wielaard from comment #2)
> > This patch makes cachegrind/tests/Makefile.am executable, which I think is
> > wrong.
> 
> Done.
> 
> > In dhat/tests/copy.c, which test for && defined(__GNUC__)?
> > Is mempcpy defined if __GNUC__ isn't on freebsd?
> 
> I think that it is not defined at all (it's nowhere in /usr/include), but
> clang has it as a builtin.

__GNUC__ is a Clang built-in:

$ cc -x c -dM -E /dev/null | grep GNUC
#define __GNUC_MINOR__ 2
#define __GNUC_PATCHLEVEL__ 1
#define __GNUC_STDC_INLINE__ 1
#define __GNUC__ 4

mempcpy was added in:

commit ee37f64cf875255338f917a9da76c643cf59786c
Author: Konstantin Belousov <k...@freebsd.org>
Date:   Wed Jul 14 18:41:36 2021 +0300

    libc: add mempcpy(3) and wmempcpy(3)

    Reviewed by:    markj
    Sponsored by:   The FreeBSD Foundation
    MFC after:      1 week
    Differential revision:  https://reviews.freebsd.org/D31180

Testing (defined(VGO_freebsd) && defined(__GNUC__)) seems a bit strange -
probably the right thing to do is just drop the __GNUC__ condition now, and
then also remove VGO_freebsd in several months, when all supported FreeBSD
branches have mempcpy.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to