https://bugs.kde.org/show_bug.cgi?id=448740
Vlad Zahorodnii <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas |ma/kwin/commit/b572aadfd56e |ma/kwin/commit/fc8b2a14b2af |cff397bc7b2916923bd1337097e |812fb87ad3ed94dafb9a253d4cc |f |7 --- Comment #3 from Vlad Zahorodnii <[email protected]> --- Git commit fc8b2a14b2af812fb87ad3ed94dafb9a253d4cc7 by Vlad Zahorodnii. Committed on 21/01/2022 at 15:39. Pushed by vladz into branch 'Plasma/5.24'. wayland: Allow setting "no border" flag even without xdg decoration Historically, noBorder() was used for two things: * as a substitute for AbstractClient::isDecorated() * to determine whether the AbstractClient should have a decoration With async decoration updates refactoring, a few things around noBorder() have changed, which exposed an existing bug in the handling of borderless maximized windows. It's possible to have a case where an initially maximized window makes an xdg_toplevel.set_maximized request before the initial commit, but creates the decoration object after the initial commit. Since XdgToplevelClient::userCanSetNoBorder() would return false when maximize() is called in XdgToplevelClient::initialize(), m_userNoBorder won't be updated and therefore the window can end up having a server side decoration. Previously, it wasn't the case because kwin would do nothing if the decoration is installed and its preferred mode changes after the initial commit but before the surface is mapped. With async decoration fixes, kwin would react as expected, which unfortunately has exposed the bug. The root cause of the problem is the fact that noBorder() is overloaded, which makes it error-prone. This patch changes how the noBorder property is treated. Now, it only indicates whether the compositor wants the window to have no borders. If noBorder() is true, it means that the compositor doesn't want the window to have a server-side decoration; on the other hand, if noBorder() is false, it doesn't imply that the window should have a decoration. (cherry picked from commit b572aadfd56ecff397bc7b2916923bd1337097ef) M +1 -1 autotests/integration/dbus_interface_test.cpp M +3 -1 src/useractions.cpp M +1 -4 src/xdgshellclient.cpp https://invent.kde.org/plasma/kwin/commit/fc8b2a14b2af812fb87ad3ed94dafb9a253d4cc7 -- You are receiving this mail because: You are watching all bug changes.
