https://bugs.kde.org/show_bug.cgi?id=352395

austinengl...@gmail.com <austinengl...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101951|0                           |1
        is obsolete|                            |
 Attachment #102288|0                           |1
        is obsolete|                            |

--- Comment #9 from austinengl...@gmail.com <austinengl...@gmail.com> ---
Created attachment 102375
  --> https://bugs.kde.org/attachment.cgi?id=102375&action=edit
try 5

Try 5 only updates the header if if has changed, and moves the git/svn parsing
code to a Makefile variable.

Additionally, in the case of git svn, it checks that .git/svn exists rather
than .git. There are (unofficial) git repos for valgrind, e.g.,
https://github.com/mslusarz/valgrind, that this would fail for. Adding git
support would be doable, but I don't think it's worth it when valgrind itself
is on SVN. I'd like git svn to be supported for the official tree (since that's
what I use for development) :).

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to