https://bugs.kde.org/show_bug.cgi?id=352395
--- Comment #11 from Philippe Waroquiers <philippe.waroqui...@skynet.be> ---
(In reply to austinengl...@gmail.com from comment #10)
> (In reply to Ivo Raisr from comment #7)
> > What happens (and what is the version) if this is run not inside a SVN/GIT
> > repository? For example one can run 'make dist', take the tarball, unpack it
> > somewhere else and build the stuff again.
>
> The svn revisions are empty. E.g., in the case of an SVN/git svn checkout:
> austin@austin2:~/src/valgrind$ ./vg-in-place -v --version
> valgrind-3.12.0.SVN-16106M-vex-3283
> austin@austin2:~/src/valgrind$ ./vg-in-place --version
> valgrind-3.12.0.SVN
>
> and not:
> austin@austin2:~/src/valgrind$ ./vg-in-place -v --version
> valgrind-3.12.0.SVN--vex-
> austin@austin2:~/src/valgrind$ ./vg-in-place --version
> valgrind-3.12.0.SVN
I known close to 0 about the make dist and how the tarball is done,
but still giving my 2 cents:
As long as we run 'make dist' in an svn (or git svn), it should
either build or update vgversion.h
so that the distr tarball contains a vgversion.h
then if make is done in an unpacked place (without being an SVN directory),
then vgversion.h should not be modified.
In other words, if we have a command such as:
create_or_update_vgversion_h
which:
if "inside svn or git svn, and vgversion.h does not exist or differs
from current svn version,
then (re-)create vgversion.h from git svn/svn
else if vgversion.h exists
do nothing // this must be the vgversion.h created when the tarball
was done
// or source files have been copied somewhere else so just
keep
// the version which is present
else
create a vgversion.h with empty versions // copied source files; no
svn, so cannot
// do better
Then we need to call create_or_update_vgversion_h as part of:
make dist
make
??? maybe some other targets ?
to ensure vgversion.h always contain (as much as possible) the svn version
it originates from.
--
You are receiving this mail because:
You are watching all bug changes.
