On Monday 14 March 2011, Michael Jansen wrote: > Find attached what i have so far. It is not active or documented yet. Just > for a review of the general logic. > > I found a problem (or overanalyze here). How can i find out if the > installation prefix of ruby is the same as the installation prefix of cmake > if autoconf (ruby uses it) provides --exec_prefix, --prefix and --libdir > options? > > Perhaps just compare rbcofigs prefix and CMAKE_INSTALL_PREFIX and be done? > If someone plays with those options (s)he deserves the problems? > > Mike
0002-Reorder-stuff-in-the-hope-it-is-more-readable-and-un.patch I don't think this patch improves readability. 0003-More-commenting.patch IMHO this one doesn't really improve the comments. -# if ruby > 1.8 is required or if ruby > 1.8 was found, search for the config.h dir +# +### FIND THE CONFIG.H FILE (IF > RUBY 1.8) +# IMO not better than before. +# +### CALL FindPackageHandleStandardArgs +# INCLUDE(FindPackageHandleStandardArgs) SET(_RUBY_REQUIRED_VARS RUBY_EXECUTABLE RUBY_INCLUDE_DIR RUBY_LIBRARY) This comment doesn't add any information. And why are they all UPPERCASE ? 0004-1st-Step-Construct-the-custom-installation-area.patch Looks good. 0005-2nd-step-Implement-the-logic.patch Looks ok IMO. Alex
_______________________________________________ Kde-buildsystem mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-buildsystem
