On Monday 14 March 2011, Alexander Neundorf wrote: > On Monday 14 March 2011, Michael Jansen wrote: ... > 0002-Reorder-stuff-in-the-hope-it-is-more-readable-and-un.patch > I don't think this patch improves readability. > > 0003-More-commenting.patch > IMHO this one doesn't really improve the comments. > > -# if ruby > 1.8 is required or if ruby > 1.8 was found, search for the > config.h dir +# > +### FIND THE CONFIG.H FILE (IF > RUBY 1.8) > +# > IMO not better than before. > > +# > +### CALL FindPackageHandleStandardArgs > +# > INCLUDE(FindPackageHandleStandardArgs) > SET(_RUBY_REQUIRED_VARS RUBY_EXECUTABLE RUBY_INCLUDE_DIR RUBY_LIBRARY) > > This comment doesn't add any information. > > And why are they all UPPERCASE ?
Or to put it in other words: I kind-of maintain (i.e. fix bugs from time to time) the FindRuby.cmake in CMake, and I don't feel like merging these two patches into cmake, since they do not really improve the file IMO. Alex _______________________________________________ Kde-buildsystem mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-buildsystem
