----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103818/#review10314 -----------------------------------------------------------
Ship it! Please commit after fixing the last issue. ConfigureChecks.cmake <http://git.reviewboard.kde.org/r/103818/#comment8508> This change is also not needed. the cmake/modules dir is already included by the main CMakeLists.txt - Christophe Giboudeaux On Feb. 2, 2012, 11:28 a.m., Michael Palimaka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103818/ > ----------------------------------------------------------- > > (Updated Feb. 2, 2012, 11:28 a.m.) > > > Review request for Build System. > > > Description > ------- > > kcheckpass and KDM support being built without PAM, but this selection is > currently automagic. > > This patch adds a WITH_PAM option, and makes sure that the patched cmake > modules are preferred over the system ones. > > > Diffs > ----- > > ConfigureChecks.cmake fe06d9e > cmake/modules/UnixAuth.cmake 904f0cb > > Diff: http://git.reviewboard.kde.org/r/103818/diff/diff > > > Testing > ------- > > For me, both kcheckpass and KDM link against libcrypt instead of PAM and work > fine when -DWITH_PAM=no is specified. > > > Thanks, > > Michael Palimaka > >
_______________________________________________ Kde-buildsystem mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-buildsystem
