On Sunday 19 February 2012 10:18:50 Alexander Neundorf wrote: > On Saturday 18 February 2012, David Faure wrote: > > On Friday 17 February 2012 18:31:58 Alexander Neundorf wrote: > > > I'm not quite sure in the code above in which cases there is a "bad > > > allocator", and whether "-Werror=return-type > > > -fvisibility-inlines-hidden" > > > is something everybody should do or not. > > > > -Werror=return-type is completely unrelated. It has been moved there > > because this is inside if (GCC_IS_NEWER_THAN_4_2), and this flag didn't > > exist before 4.2. See commit 66027ca3a94848246eef2618a342ddc6ece0a00c. > > > > Bad allocator is probably about old versions of gcc too. > > Thanks. > > > I would think we can drop all these "old gcc" hacks in frameworks. > > I was thinking about this too, but I came to the conclusion that the file > KDECompilerSettings.cmake, as it is now, i.e. including the stuff for these > old compilers, can be used by *any* other project too, not only KDE > frameworks, and those are free to use older compiler versions. > > I am actually thinking about modifying FindKDE4Internal.cmake in the 4.x > branch to make use of it too (...in the future when e-c-m and cmake 2.8.8 > will have been released), for maintainace reasons.
Makes sense. -- David Faure, [email protected], http://www.davidfaure.fr Sponsored by Nokia to work on KDE, incl. KDE Frameworks 5 _______________________________________________ Kde-buildsystem mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-buildsystem
