----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104545/#review12328 -----------------------------------------------------------
Ship it! I didn't test it or check in detail (like e.g. that the target name is spelled correctly), but it odes the right thing in general. - Alexander Neundorf On April 11, 2012, 5:05 a.m., Raphael Kubo da Costa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104545/ > ----------------------------------------------------------- > > (Updated April 11, 2012, 5:05 a.m.) > > > Review request for Build System and Trever Fischer. > > > Description > ------- > > Besides the exported targes file and the Config file having different > purposes, so far applications wishing to use libkcompactdisc (such as kscd) > had to use the full imported target name (which was weirdly named > `KDE::Libkcompactdisckcompactdisc') instead of a variable such as > `LIBKCOMPACTDISC_LIBRARIES'. > > We now have a LibkcompactdiscConfig.cmake.in file which is used to generate a > proper Config file. It currently defines the `LIBKCOMPACTDISC_INCLUDE_DIRS' > and `LIBKCOMPACTDISC_LIBRARIES' variables and includes the exported targets > file, which is now named LibkcompactdiscTargets.cmake. > > > Diffs > ----- > > CMakeLists.txt b41dbf5 > LibkcompactdiscConfig.cmake.in PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/104545/diff/ > > > Testing > ------- > > With the analogous change <https://git.reviewboard.kde.org/r/104544/> made to > libkcddb I can finally build kscd again. > > > Thanks, > > Raphael Kubo da Costa > >
_______________________________________________ Kde-buildsystem mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-buildsystem
