----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104544/#review13751 -----------------------------------------------------------
This review has been submitted with commit 4d9e251c2e5d50a72c29030b2859cd7794b55351 by Raphael Kubo da Costa to branch master. - Commit Hook On April 11, 2012, 4:51 a.m., Raphael Kubo da Costa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104544/ > ----------------------------------------------------------- > > (Updated April 11, 2012, 4:51 a.m.) > > > Review request for Build System and Trever Fischer. > > > Description > ------- > > Besides the exported targes file and the Config file having different > purposes, so far applications wishing to use libkcddb (such as kscd) had to > use the full imported target name (which was weirdly named > `KDE::Libkcddbkcddb') instead of a variable such as `LIBKCDDB_LIBRARIES'. > > We now have a LibkcddbConfig.cmake.in file which is used to generate a proper > Config file. It currently defines the `LIBKCDDB_INCLUDE_DIRS' and > `LIBKCDDB_LIBRARIES' variables and includes the exported targets file, which > is now named LibkcddbTargets.cmake. > > > Diffs > ----- > > CMakeLists.txt 5ad2eb1 > LibkcddbConfig.cmake.in PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/104544/diff/ > > > Testing > ------- > > With the analogous change made to libkcompactdisc I can finally build kscd > again. > > > Thanks, > > Raphael Kubo da Costa > >
_______________________________________________ Kde-buildsystem mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-buildsystem
