----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104558/#review12442 -----------------------------------------------------------
This review has been submitted with commit 1554ba408633397066d31c3d565c217b5a385fb8 by Michael Palimaka to branch KDE/4.8. - Commit Hook On April 14, 2012, 6:42 p.m., Michael Palimaka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104558/ > ----------------------------------------------------------- > > (Updated April 14, 2012, 6:42 p.m.) > > > Review request for Build System and kwin. > > > Description > ------- > > When compiling kwin with GLES and without OpenGL, build fails because some > parts do not realise that GLES is being used. This is because of > KWIN_HAVE_OPENGLES_COMPOSITING being previously removed in > 026e0f418d27466a6fe855bbe95a50ea5dd71b4b and some references being missed. > > This patch switches the conditional to OPENGLES_FOUND, so that > -DKWIN_HAVE_OPENGLES is again passed to the build disabling OpenGL-only > features. > > > Diffs > ----- > > kwin/kcmkwin/kwinscreenedges/CMakeLists.txt > 282735087ba7ecd37ec96bdc05e8ef0a03e4dc8e > kwin/effects/CMakeLists.txt 6f0ef11e87c6cb5895c5843fa5bb91cf72a6e800 > kwin/kcmkwin/kwincompositing/CMakeLists.txt > 2d420c06941138eefb7058458549da4df42bd70a > > Diff: http://git.reviewboard.kde.org/r/104558/diff/ > > > Testing > ------- > > Builds with OpenGL on & GLES off, OpenGL off & GLES on, and both OpenGL & > GLES on complete as expected. In each case, the appropriate OpenGL or > GLES-specific libraries were built. > > > Thanks, > > Michael Palimaka > >
_______________________________________________ Kde-buildsystem mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-buildsystem
