On Tuesday 09 December 2014 21:32:28 Stephen Kelly wrote: > Alex Merry wrote: > > On Monday 08 December 2014 23:58:25 Alex Merry wrote: > >> I think the right plan is to: > >> * port KF5 to use CMAKE_INSTALL_* variables > >> * warn about using the old variables on the command line > >> * when KF6 and/or e-c-m 2.0 happens (whether or not those happen in > >> sync), ** ditch the old variable names > >> ** use a KDE_INSTALL_* prefix for all variables > >> ** keep the CMAKE_INSTALL_* versions of the variables, but deprecate > >> their use in CMakeLists files, and deprecate the use of any that aren't > >> in GNUInstallDirs on the command line > > > > Actually, having thought about it a bit more (that's what my commute to > > > work's for, right?): > Yes, this is better. > > > * add KDE_INSTALL_* variables, and document them as the recommended > > Not KF5_? I didn't think long about it so I don't know which is better.
Nope, KDE_. The variables that are KF5-specific already have a 5 in the name. As a bonus, having KDE_INSTALL_* variables come from KDEInstallDirs.cmake should make it easier for people reading CMakeLists.txt files of KDE projects. > > * port KF5 (and the KF5 CMake porting scripts) to use them > > * warn about using the old variables > > There are now two levels of 'old', right? Do you include the CMAKE_INSTALL_* > ones defined by KDE in that 'old'? The ones that are not in GNUInstallDirs, yes. Alex _______________________________________________ Kde-buildsystem mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-buildsystem
