> On Aug. 9, 2015, 9:34 a.m., David Faure wrote: > > modules/ksb/BuildSystem.pm, line 73 > > <https://git.reviewboard.kde.org/r/124613/diff/1/?file=389799#file389799line73> > > > > Are you sure? I found code in Module.pm line 509 that creates a > > .refresh-me file right after printing out "Unable to configure".
Oh, good catch. .refresh-me was added for the purpose I described but I see that I did take advantage of that elsewhere. Since a user is unlikely to ever use .refresh-me themselves I think you're right here after all, I withdraw the issue. Though perhaps a comment pointing to Module.pm might be appropriate if this even caught myself. :) > On Aug. 9, 2015, 9:34 a.m., David Faure wrote: > > modules/ksb/BuildSystem.pm, line 79 > > <https://git.reviewboard.kde.org/r/124613/diff/1/?file=389799#file389799line79> > > > > what does // 0 mean btw? This returns the value 0 if the expression on the left is undefined. similar to "$foo || 0" except that "|| 0" also works when $foo is defined-but-boolean-false. This is just quick inline validation that avoids annoying Perl warnings about comparison with undefined values. > On Aug. 9, 2015, 9:34 a.m., David Faure wrote: > > modules/ksb/BuildSystem.pm, line 82 > > <https://git.reviewboard.kde.org/r/124613/diff/1/?file=389799#file389799line82> > > > > Well, either that or the user manually wiped out the contents of the > > builddir (but not the builddir itself). > > (or kdesrc-build looks for the wrong file, in case of a bug). > > > > I'd like to keep the output as precise as possible, so one can figure > > out why exactly this is happening... Fair enough, I withdraw the issue. - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124613/#review83595 ----------------------------------------------------------- On Aug. 9, 2015, 9:36 a.m., David Faure wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124613/ > ----------------------------------------------------------- > > (Updated Aug. 9, 2015, 9:36 a.m.) > > > Review request for Build System and Michael Pyne. > > > Repository: kdesrc-build > > > Description > ------- > > i.e. be more precise than "meets other building criteria" > > REVIEW: 124613 > > > Diffs > ----- > > modules/ksb/IPC.pm 0e55c5fe5c2a8771f6b9b159a684bdcc6dda52a7 > modules/ksb/Module.pm a7a7fbcc5e30cbb4c52979d87407a3250b80f2b2 > modules/ksb/l10nSystem.pm e5756f85026ad9b95533d2989746ab91f87920a6 > modules/ksb/BuildSystem.pm 24963040d77dc93f8f86a2f19755c617713bbd8a > > Diff: https://git.reviewboard.kde.org/r/124613/diff/ > > > Testing > ------- > > Example: > > $ kdesrc-build --refresh plasma-nm > > Building plasma-nm from kf5-network-management (1/1) > Updating plasma-nm (to branch master) > No source update, but the option refresh-build was set > Source update complete for plasma-nm: no files affected > Preparing build system for plasma-nm. > ... > > > Thanks, > > David Faure > >
_______________________________________________ Kde-buildsystem mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-buildsystem
