----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124595/#review83897 -----------------------------------------------------------
+1 This is really useful modules/ECMQtDeclareLoggingCategory.cmake (line 12) <https://git.reviewboard.kde.org/r/124595/#comment58121> maybe CATEGORY_NAME instead? modules/ECMQtDeclareLoggingCategory.cpp (line 1) <https://git.reviewboard.kde.org/r/124595/#comment58120> Is this file supposed to be part of the commit? Seems to me like just the .in would be enough modules/ECMQtDeclareLoggingCategory.h (line 1) <https://git.reviewboard.kde.org/r/124595/#comment58119> same here - Alex Richardson On Aug. 3, 2015, 11:06 a.m., Alex Merry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124595/ > ----------------------------------------------------------- > > (Updated Aug. 3, 2015, 11:06 a.m.) > > > Review request for Extra Cmake Modules and David Faure. > > > Repository: extra-cmake-modules > > > Description > ------- > > This makes life a bit easier for developers who use the categorised > logging in Qt5 in the common case - rather than creating two new files, > and remembering to put in the #ifdef for the default verbosity settings > in Qt 5.4, they can just add a couple of lines to their CMakeLists.txt. > > (NB: see https://codereview.qt-project.org/#/c/122641 for patch for the Qt > bug mentioned in the docs). > > > Diffs > ----- > > docs/module/ECMQtDeclareLoggingCategory.rst PRE-CREATION > modules/ECMQtDeclareLoggingCategory.cmake PRE-CREATION > modules/ECMQtDeclareLoggingCategory.cpp PRE-CREATION > modules/ECMQtDeclareLoggingCategory.cpp.in PRE-CREATION > modules/ECMQtDeclareLoggingCategory.h PRE-CREATION > modules/ECMQtDeclareLoggingCategory.h.in PRE-CREATION > tests/CMakeLists.txt 7960154a42ec083be61aec2bd066b072560beb61 > tests/ECMQtDeclareLoggingCategoryTest/CMakeLists.txt PRE-CREATION > tests/ECMQtDeclareLoggingCategoryTest/testmain.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/124595/diff/ > > > Testing > ------- > > Added unit test runs and passes. Documentation builds and looks sane. > > > Thanks, > > Alex Merry > >
_______________________________________________ Kde-buildsystem mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-buildsystem
