----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124595/ -----------------------------------------------------------
(Updated Aug. 18, 2015, 10:02 p.m.) Status ------ This change has been marked as submitted. Review request for Extra Cmake Modules and David Faure. Changes ------- Submitted with commit 9bffa7a202cad3a29103f3e9a8b50b9a61277310 by Alex Merry to branch master. Repository: extra-cmake-modules Description ------- This makes life a bit easier for developers who use the categorised logging in Qt5 in the common case - rather than creating two new files, and remembering to put in the #ifdef for the default verbosity settings in Qt 5.4, they can just add a couple of lines to their CMakeLists.txt. (NB: see https://codereview.qt-project.org/#/c/122641 for patch for the Qt bug mentioned in the docs). Diffs ----- tests/ECMQtDeclareLoggingCategoryTest/testmain.cpp PRE-CREATION tests/ECMQtDeclareLoggingCategoryTest/CMakeLists.txt PRE-CREATION tests/CMakeLists.txt 7960154a42ec083be61aec2bd066b072560beb61 modules/ECMQtDeclareLoggingCategory.h.in PRE-CREATION modules/ECMQtDeclareLoggingCategory.cpp.in PRE-CREATION docs/module/ECMQtDeclareLoggingCategory.rst PRE-CREATION modules/ECMQtDeclareLoggingCategory.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/124595/diff/ Testing ------- Added unit test runs and passes. Documentation builds and looks sane. Thanks, Alex Merry
_______________________________________________ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem
