> On Sept. 12, 2015, 12:35 nachm., Olivier Goffart wrote: > > modules/ECMInstallIcons.cmake, line 201 > > <https://git.reviewboard.kde.org/r/125192/diff/1/?file=402974#file402974line201> > > > > I believe you also need to pass '-f' or it won't regenerate the cache > > Volker Krause wrote: > It does here, and the docs confirm -f is only needed to override an > already up-to-date cache, not for cases where it is outdated.
Indeed. - Olivier ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125192/#review85254 ----------------------------------------------------------- On Sept. 12, 2015, 12:23 nachm., Volker Krause wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125192/ > ----------------------------------------------------------- > > (Updated Sept. 12, 2015, 12:23 nachm.) > > > Review request for Extra Cmake Modules and Olivier Goffart. > > > Repository: extra-cmake-modules > > > Description > ------- > > Despite the name, Qt is also using this, and it considerably speeds up > icon lookup. > > > Diffs > ----- > > modules/ECMInstallIcons.cmake 79dc5150e8a966db2a9fdd39cbd5ce8c2f842e18 > > Diff: https://git.reviewboard.kde.org/r/125192/diff/ > > > Testing > ------- > > Built and installed kdepim, cache files are generated in the expected places. > > > Thanks, > > Volker Krause > >
_______________________________________________ Kde-buildsystem mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-buildsystem
