> On Sept. 13, 2015, 9:27 p.m., David Faure wrote: > > modules/ECMInstallIcons.cmake, line 187 > > <https://git.reviewboard.kde.org/r/125192/diff/1/?file=402974#file402974line187> > > > > Olivier, I was wrong! You can remove the recursive mtime check from Qt, > > if the rule is always that any icon installation must touch the toplevel > > dir. Which clearly we were doing already. Sorry for the wrong advice on my > > part. > > Olivier Goffart wrote: > David: but does the package manager that contains icons will touch the > theme directory?
Ah, good question. No idea though. That's a question for [email protected], where the packagers will be able to answer you. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125192/#review85334 ----------------------------------------------------------- On Sept. 12, 2015, 12:23 p.m., Volker Krause wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125192/ > ----------------------------------------------------------- > > (Updated Sept. 12, 2015, 12:23 p.m.) > > > Review request for Extra Cmake Modules and Olivier Goffart. > > > Repository: extra-cmake-modules > > > Description > ------- > > Despite the name, Qt is also using this, and it considerably speeds up > icon lookup. > > > Diffs > ----- > > modules/ECMInstallIcons.cmake 79dc5150e8a966db2a9fdd39cbd5ce8c2f842e18 > > Diff: https://git.reviewboard.kde.org/r/125192/diff/ > > > Testing > ------- > > Built and installed kdepim, cache files are generated in the expected places. > > > Thanks, > > Volker Krause > >
_______________________________________________ Kde-buildsystem mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-buildsystem
