-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126303/
-----------------------------------------------------------

(Updated Jan. 19, 2016, 9:30 a.m.)


Review request for Extra Cmake Modules.


Changes
-------

Added documentation


Repository: extra-cmake-modules


Description
-------

On OSX I want to ship "Tomahawk.icns" instead of "tomahawkSources.icns" which 
is the autogenerated name for our sources variable, thus I added an optional 
paramater allowing to override the basename (without extension).


Diffs (updated)
-----

  modules/ECMAddAppIcon.cmake f90d4c3 

Diff: https://git.reviewboard.kde.org/r/126303/diff/


Testing
-------

Tested it in Tomahawk and it works.

edit1: Actually, something is fishy. Still investigating.
edit2: Nope, everything's fine. Random CMake fnord, hadn't tried a clean build.


Thanks,

Dominik Schmidt

_______________________________________________
Kde-buildsystem mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-buildsystem

Reply via email to