----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126303/#review91830 -----------------------------------------------------------
modules/ECMAddAppIcon.cmake (line 27) <https://git.reviewboard.kde.org/r/126303/#comment62690> Please add a "Since 5.19.0" (or whatever version the argument OUTFILE will appear in first) to the end of the description of the argument. - Friedrich W. H. Kossebau On Jan. 19, 2016, 9:30 a.m., Dominik Schmidt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126303/ > ----------------------------------------------------------- > > (Updated Jan. 19, 2016, 9:30 a.m.) > > > Review request for Extra Cmake Modules. > > > Repository: extra-cmake-modules > > > Description > ------- > > On OSX I want to ship "Tomahawk.icns" instead of "tomahawkSources.icns" which > is the autogenerated name for our sources variable, thus I added an optional > paramater allowing to override the basename (without extension). > > > Diffs > ----- > > modules/ECMAddAppIcon.cmake f90d4c3 > > Diff: https://git.reviewboard.kde.org/r/126303/diff/ > > > Testing > ------- > > Tested it in Tomahawk and it works. > > edit1: Actually, something is fishy. Still investigating. > edit2: Nope, everything's fine. Random CMake fnord, hadn't tried a clean > build. > > > Thanks, > > Dominik Schmidt > >
_______________________________________________ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem