> On June 8, 2016, 8:26 a.m., Nicolás Alvarez wrote: > > I looked at this a few times, researched a bit about git + symlinks + > > Windows... and I conclude that _having symlinks in the repository_ is a bad > > idea, because of the problems they cause on Windows, and this RR is not a > > good enough workaround for those problems. > > > > Instead, I propose: > > 1. delete the symlinks from the `breeze-icons` git repository > > 2. create a text file with some sort of list of "icon aliases" > > 3. make the build system create the symlinks at compile time (or install > > time) based on the icon alias list, or copies (or NTFS hardlinks?) in the > > case of Windows > > 4. add server-side git hooks to prevent symlinks from being introduced again > > > > ...which would be a big enough change that it needs discussion in mailing > > lists, and not just here :)
The module does basically exactly this, just builds up a list of symbolic links automatically. Why delete them, then? - Gleb ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128112/#review96294 ----------------------------------------------------------- On June 8, 2016, 8:08 a.m., Gleb Popov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128112/ > ----------------------------------------------------------- > > (Updated June 8, 2016, 8:08 a.m.) > > > Review request for Extra Cmake Modules. > > > Repository: extra-cmake-modules > > > Description > ------- > > When git is checking out repositories with UNIX symbolic links inside on > Windows machine, it writes them as plain text files, containing relative path > to the real file. This is the case for breeze-icons framework, for instance, > and this breaks some icons that are symlinked. > > This macro is intended to fix that. There is some room for performance > improvement, but i wanted to get the feedback early. > > > Diffs > ----- > > modules/ECMWinResolveSymlinks.cmake PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/128112/diff/ > > > Testing > ------- > > > Thanks, > > Gleb Popov > >
_______________________________________________ Kde-buildsystem mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-buildsystem
