-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128112/#review96460
-----------------------------------------------------------




modules/ECMWinResolveSymlinks.cmake (line 69)
<https://git.reviewboard.kde.org/r/128112/#comment65159>

    whitespace


- Hannah von Reth


On June 8, 2016, 5:08 a.m., Gleb Popov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128112/
> -----------------------------------------------------------
> 
> (Updated June 8, 2016, 5:08 a.m.)
> 
> 
> Review request for Extra Cmake Modules.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> When git is checking out repositories with UNIX symbolic links inside on 
> Windows machine, it writes them as plain text files, containing relative path 
> to the real file. This is the case for breeze-icons framework, for instance, 
> and this breaks some icons that are symlinked.
> 
> This macro is intended to fix that. There is some room for performance 
> improvement, but i wanted to get the feedback early.
> 
> 
> Diffs
> -----
> 
>   modules/ECMWinResolveSymlinks.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/128112/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gleb Popov
> 
>

_______________________________________________
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem

Reply via email to