> On July 27, 2016, 2:34 a.m., Matthias Klumpp wrote: > > kde-modules/test_appstream.cmake, line 1 > > <https://git.reviewboard.kde.org/r/128533/diff/1/?file=472470#file472470line1> > > > > I am not 100% sure on how this works, but would it be possible to > > validate the .desktop file and AppStream XML together? > > For that, we would need an installed copy of the metadata and .desktop > > files in some directory `$DESTDIR` and then could fire `appstreamcli > > validate-tree $DESTDIR` at it. > > That command will validate all metainfo files together with the > > .desktop files and complain on error.
What should the `appstreamcli validate` call look like? - Aleix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128533/#review97859 ----------------------------------------------------------- On July 27, 2016, 2:25 a.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128533/ > ----------------------------------------------------------- > > (Updated July 27, 2016, 2:25 a.m.) > > > Review request for Extra Cmake Modules, Matthias Klumpp and Scarlett Clark. > > > Repository: extra-cmake-modules > > > Description > ------- > > At the moment, we're validating it in build.kde.org, but I feel it will be > easier for developers to test if we do so locally. > This patch does it by seeing which `*.appdata.xml` files are being installed > and validating them. This way we can keep it generic for all KDE projects. > > > Diffs > ----- > > kde-modules/KDECMakeSettings.cmake dd37e7f > kde-modules/test_appstream.cmake PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/128533/diff/ > > > Testing > ------- > > Tested on some projects, locally. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Kde-buildsystem mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-buildsystem
