> On July 27, 2016, 12:34 a.m., Matthias Klumpp wrote: > > kde-modules/test_appstream.cmake, line 1 > > <https://git.reviewboard.kde.org/r/128533/diff/1/?file=472470#file472470line1> > > > > I am not 100% sure on how this works, but would it be possible to > > validate the .desktop file and AppStream XML together? > > For that, we would need an installed copy of the metadata and .desktop > > files in some directory `$DESTDIR` and then could fire `appstreamcli > > validate-tree $DESTDIR` at it. > > That command will validate all metainfo files together with the > > .desktop files and complain on error. > > Aleix Pol Gonzalez wrote: > What should the `appstreamcli validate` call look like? > > Matthias Klumpp wrote: > The `validate` call (not the `validate-tree` call!) takes a list of > AppStream metadata files as parameters. > E.g. `appstreamcli validate org.example.Test1.metainfo.xml > org.example.Test2.appdata.xml` > > Aleix Pol Gonzalez wrote: > I don't think we want to call validate-tree then. Maybe it would make > sense to be able to pass the desktop files there as well? > > Matthias Klumpp wrote: > Well, `validate-tree` is to validate an installed set. `validate` doesn't > know anything about .desktop files, but since .desktop files complement the > XML, it might actually not be a bad idea to add support for this to > appstreamcli. > I will look into it for the next release. > > Aleix Pol Gonzalez wrote: > Thanks. > Can we agree that this patch would be a step forward for now?
Yes - with the other issue solved, I have no objections to this. But I am also no CTest expert (so I will give it a Ship It for the AppStream side, the CMake side looks fine to me, but don't count on my work on that ^^). - Matthias ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128533/#review97859 ----------------------------------------------------------- On July 27, 2016, 10:08 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128533/ > ----------------------------------------------------------- > > (Updated July 27, 2016, 10:08 p.m.) > > > Review request for Extra Cmake Modules, Matthias Klumpp and Scarlett Clark. > > > Repository: extra-cmake-modules > > > Description > ------- > > At the moment, we're validating it in build.kde.org, but I feel it will be > easier for developers to test if we do so locally. > This patch does it by seeing which `*.appdata.xml` files are being installed > and validating them. This way we can keep it generic for all KDE projects. > > > Diffs > ----- > > kde-modules/KDECMakeSettings.cmake dd37e7f > kde-modules/appstreamtest.cmake PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/128533/diff/ > > > Testing > ------- > > Tested on some projects, locally. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem