kfunk added inline comments.

INLINE COMMENTS

> sitter wrote in KDEInstallDirs.cmake:699
> From a style perspective, I'd suggest having the prefix.sh live somewhere in 
> the installed ECM tree and get copied, rather than maintained as a glorified 
> heredoc in the cmake code. That's just a suggestion though.

Definitely, +1.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D9299

To: apol, #frameworks, sitter
Cc: kfunk, bcooksley, ngraham, sitter, cgiboudeaux, #build_system

Reply via email to