cgiboudeaux added a comment.
In https://phabricator.kde.org/D9299#179035, @cgiboudeaux wrote: > In https://phabricator.kde.org/D9299#179032, @kfunk wrote: > > > If we'd name this file somewhat less generic then it could be even installed by default, no? > > > > I had the scheme of the QNX setup script in my mind: https://github.com/acklinr/qnx660/blob/master/qnx660-env.sh > > > > Thus: Maybe rename prefix.sh to say 'ecm-env.sh' and install the file by default? > > > Files overwritting each others is a no-go for packagers. +1 for a less generic name however. Adding files in /usr directly, will also be rejected. Now that I had a closer look: KDEInstallDirs only defines some paths, I don't think this change shall be part of this file. What about moving it to its own file and sourcing it instead ? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D9299 To: apol, #frameworks, sitter Cc: kfunk, bcooksley, ngraham, sitter, cgiboudeaux, #build_system
