> On May 9, 2011, 10:45 p.m., Aurélien Gâteau wrote: > > Looks good. I would even go a bit further and suggest the following: > > - Remove the Clear button, I don't think it serves any purpose > > - Change the label of the OK button to "Create Link" > > Jonathan Marten wrote: > Good idea to remove the pointless Clear button (probably a hangover from > the days when line edit's didn't have clear buttons). Not possible to change > the OK button text, though, because this is a general dialogue which may be > used in other places. > > Christoph Feck wrote: > I think the dialog is more generic and is (could?) also be used by > programs for adding bookmarks or something else, so labeling the button > "Create Link" could be confusing. > > The Clear button is really a relict, and it can be removed if the fields > have a standard KLineEdit clear button already.
Oh, two idiots adding the same comment at the same time ;) - Christoph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101312/#review3233 ----------------------------------------------------------- On May 8, 2011, 3:42 p.m., Jonathan Marten wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101312/ > ----------------------------------------------------------- > > (Updated May 8, 2011, 3:42 p.m.) > > > Review request for kdelibs. > > > Summary > ------- > > This dialogue - used, for example, for the desktop's "Create New - Link to > Location" or "Create New - Basic link to" actions, has a very ugly layout > where the labels are squashed up to the entry fields and the two lines are > not vertically aligned with each other. This change uses a form layout > instead, which automatically adopts the standard KDE style and spacing. > > In addition to the layout, the "OK" button is enabled when the dialogue is > first shown; it should not be because the two entry fields are empty. This is > checked at the end of the constructor. > > > Diffs > ----- > > kfile/knameandurlinputdialog.cpp fd02af6 > > Diff: http://git.reviewboard.kde.org/r/101312/diff > > > Testing > ------- > > Built kdelibs with these changes, checked operation and appearance of > dialogue via Plasma desktop. > > > Screenshots > ----------- > > Before > http://git.reviewboard.kde.org/r/101312/s/158/ > After > http://git.reviewboard.kde.org/r/101312/s/159/ > > > Thanks, > > Jonathan > >