----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101312/#review3242 -----------------------------------------------------------
This review has been submitted with commit b93fb69f8812782be665897e266271fba48754bd by Jonathan Marten. - Commit On May 8, 2011, 3:42 p.m., Jonathan Marten wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101312/ > ----------------------------------------------------------- > > (Updated May 8, 2011, 3:42 p.m.) > > > Review request for kdelibs. > > > Summary > ------- > > This dialogue - used, for example, for the desktop's "Create New - Link to > Location" or "Create New - Basic link to" actions, has a very ugly layout > where the labels are squashed up to the entry fields and the two lines are > not vertically aligned with each other. This change uses a form layout > instead, which automatically adopts the standard KDE style and spacing. > > In addition to the layout, the "OK" button is enabled when the dialogue is > first shown; it should not be because the two entry fields are empty. This is > checked at the end of the constructor. > > > Diffs > ----- > > kfile/knameandurlinputdialog.cpp fd02af6 > > Diff: http://git.reviewboard.kde.org/r/101312/diff > > > Testing > ------- > > Built kdelibs with these changes, checked operation and appearance of > dialogue via Plasma desktop. > > > Screenshots > ----------- > > Before > http://git.reviewboard.kde.org/r/101312/s/158/ > After > http://git.reviewboard.kde.org/r/101312/s/159/ > > > Thanks, > > Jonathan > >
